Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decimal types to cuIO benchmarks #9776

Merged
merged 37 commits into from
Dec 17, 2021
Merged

Add decimal types to cuIO benchmarks #9776

merged 37 commits into from
Dec 17, 2021

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Nov 25, 2021

Closes #9769
Depends on #9775

Benchmarks now include decimal32/64/128 columns for all supported formats.
Also fixes an issue in distribution factory, which caused all normal distributions to generate upper_bound in many cases.

@vuule vuule added tests Unit testing for project libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue improvement Improvement / enhancement to an existing function labels Nov 25, 2021
@vuule vuule self-assigned this Nov 25, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 25, 2021
@vuule vuule added non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Nov 25, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021 •
edited
Loading

Codecov Report

Merging #9776 (349e023) into branch-22.02 (967a333) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9776      +/-   ##
================================================
- Coverage         10.49%   10.40%   -0.09%     
================================================
  Files               119      119              
  Lines             20305    20501     +196     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18367     +192
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc2a32a...349e023. Read the comment docs.

vuule and others added 13 commits November 29, 2021 11:10
@vuule
Merge branch 'branch-22.02' of https://github.com/rapidsai/cudf into …
0f664f9 
…fea-decimal-benchmark-gen
@vuule
Merge branch 'branch-22.02' of https://github.com/rapidsai/cudf into …
c5966a3 
…bug-dec128-from-precision
@vuule
Merge branch 'branch-22.02' of https://github.com/rapidsai/cudf into …
1fb2164 
…bug-dec128-from-precision
@vuule
decode as decimal32
761ed54
@vuule
read as dec32 when possible; update tests; disable dec128 from python
6e11f75
@vuule
Merge branch 'branch-22.02' of https://github.com/rapidsai/cudf into …
41ac21c 
…bug-dec128-from-precision
@vuule
set scale for decimal32
7df6e76
@vuule
adjust Java test
fe03e08
@vuule
java fix try 2
b98b4a8
@jlowe
Remove deprecated methods from Java Table class
1869255
@vuule
Merge branch 'branch-22.02' of https://github.com/rapidsai/cudf into …
509a153 
…bug-dec128-from-precision
@vuule
Merge commit 'refs/pull/9853/head' of https://github.com/rapidsai/cudf …
fd1c6da 
…into bug-dec128-from-precision
@vuule
Merge branch 'bug-dec128-from-precision' of https://github.com/vuule/…
d56b9b9 
…cudf into bug-dec128-from-precision
@github-actions github-actions bot added the CMake CMake build issue label Dec 9, 2021
@github-actions github-actions bot removed the CMake CMake build issue label Dec 10, 2021
@vuule vuule marked this pull request as ready for review December 10, 2021 23:00
@vuule vuule requested a review from a team as a code owner December 10, 2021 23:00
@vuule vuule requested review from devavret and nvdbaranec December 10, 2021 23:00
@vuule vuule requested a review from nvdbaranec December 15, 2021 00:16
@vuule vuule mentioned this pull request Dec 15, 2021
Merged
@vuule
Copy link
Contributor Author

vuule commented Dec 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ce02856 into rapidsai:branch-22.02 Dec 17, 2021
@vuule vuule deleted the fea-decimal-benchmark-gen branch December 17, 2021 23:45
@karthikeyann karthikeyann mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdbaranec nvdbaranec nvdbaranec approved these changes

@devavret devavret devavret approved these changes

Assignees

@vuule vuule

Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Cover decimal types in C++ cuIO benchmarks
4 participants
@vuule @devavret @nvdbaranec @jlowe