Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert regex $/EOL end-of-string new-line special case handling #9774

Merged
merged 4 commits into from
Dec 10, 2021
Merged

Revert regex $/EOL end-of-string new-line special case handling #9774

merged 4 commits into from
Dec 10, 2021

Conversation

davidwendt
Copy link
Contributor

Closes #9764

This reverts the change made in #9620 for the reasons given in #9764 (comment)

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) non-breaking Non-breaking change labels Nov 24, 2021
@davidwendt davidwendt self-assigned this Nov 24, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021 •
edited
Loading

Codecov Report

Merging #9774 (150fc72) into branch-22.02 (967a333) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 150fc72 differs from pull request most recent head 208dd88. Consider uploading reports for the commit 208dd88 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9774      +/-   ##
================================================
- Coverage         10.49%   10.47%   -0.02%     
================================================
  Files               119      119              
  Lines             20305    20341      +36     
================================================
  Hits               2130     2130              
- Misses            18175    18211      +36
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4629037...208dd88. Read the comment docs.

@github-actions github-actions bot added the Java Affects Java cuDF API. label Nov 30, 2021
@github-actions github-actions bot removed the Java Affects Java cuDF API. label Nov 30, 2021
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 30, 2021
@davidwendt davidwendt marked this pull request as ready for review November 30, 2021 18:42
@davidwendt davidwendt requested review from a team as code owners November 30, 2021 18:42
@davidwendt davidwendt mentioned this pull request Dec 10, 2021
Closed
andygrove
andygrove approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c012de5 into rapidsai:branch-22.02 Dec 10, 2021
@davidwendt davidwendt deleted the revert-eol-newline-wec branch December 10, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@vyasr vyasr vyasr approved these changes

@andygrove andygrove andygrove approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API. strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Regex \n at end of string change in issue 9620 broken string to timestamp behavior
4 participants
@davidwendt @andygrove @vyasr @hyperbolic2346