Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some doxygen warnings and add missing documentation #9770

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

karthikeyann
Copy link
Contributor

fix to ignore __device__ void return type warnings.
add missing documentation on some functions
Correct doxygen doc style comment fixes

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Nov 24, 2021
@karthikeyann karthikeyann requested a review from a team as a code owner November 24, 2021 10:20
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #9770 (20ddd3d) into branch-22.02 (967a333) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 20ddd3d differs from pull request most recent head 1602867. Consider uploading reports for the commit 1602867 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9770      +/-   ##
================================================
- Coverage         10.49%   10.47%   -0.02%     
================================================
  Files               119      119              
  Lines             20305    20332      +27     
================================================
  Hits               2130     2130              
- Misses            18175    18202      +27     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1811b5...1602867. Read the comment docs.

@karthikeyann
Copy link
Contributor Author

rerun tests

@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1eabcb7 into rapidsai:branch-22.02 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants