Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing streams #9767

Merged
merged 8 commits into from
Dec 9, 2021

Conversation

karthikeyann
Copy link
Contributor

@karthikeyann karthikeyann commented Nov 23, 2021

fix missing stream argument in default argument of functions.
And also in some cases, mr on returned objects creation.

This cleanup is done as a follow up after PR #9679

Almost all of libcudf functions usages of stream arg are cleaned up.
Missing mr still might need another clean up.

@karthikeyann karthikeyann added bug Something isn't working 2 - In Progress Currently a work in progress cuda libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #9767 (c535375) into branch-22.02 (967a333) will decrease coverage by 0.05%.
The diff coverage is 5.85%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9767      +/-   ##
================================================
- Coverage         10.49%   10.43%   -0.06%     
================================================
  Files               119      119              
  Lines             20305    20449     +144     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18315     +140     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/json.py 0.00% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8002cbd...c535375. Read the comment docs.

@karthikeyann karthikeyann marked this pull request as ready for review December 6, 2021 20:37
@karthikeyann karthikeyann requested a review from a team as a code owner December 6, 2021 20:37
@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond and removed 2 - In Progress Currently a work in progress labels Dec 6, 2021
Copy link
Contributor

@nvdbaranec nvdbaranec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am terrified at how much you uncovered.

cpp/src/groupby/hash/groupby.cu Show resolved Hide resolved
cpp/src/unary/cast_ops.cu Outdated Show resolved Hide resolved
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finds! Unfortunately I don't see a way to avoid this problem from recurring without removing default stream parameters as recommended in #9854.

@karthikeyann karthikeyann added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Dec 9, 2021
@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 024003c into rapidsai:branch-22.02 Dec 9, 2021
@bdice bdice mentioned this pull request Oct 21, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants