-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing streams #9767
Fix missing streams #9767
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9767 +/- ##
================================================
- Coverage 10.49% 10.43% -0.06%
================================================
Files 119 119
Lines 20305 20449 +144
================================================
+ Hits 2130 2134 +4
- Misses 18175 18315 +140
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am terrified at how much you uncovered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice finds! Unfortunately I don't see a way to avoid this problem from recurring without removing default stream parameters as recommended in #9854.
@gpucibot merge |
fix missing
stream
argument in default argument of functions.And also in some cases,
mr
on returned objects creation.This cleanup is done as a follow up after PR #9679
Almost all of libcudf functions usages of stream arg are cleaned up.
Missing
mr
still might need another clean up.