Refactor TableTest assertion methods to a separate utility class #9762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
added
tests
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9762 +/- ##
================================================
+ Coverage 10.49% 10.56% +0.07%
================================================
Files 119 119
Lines 20305 20364 +59
================================================
+ Hits 2130 2151 +21
- Misses 18175 18213 +38
Continue to review full report at Codecov.
|
gerashegalov
approved these changes
Nov 23, 2021
| * @param expect The expected result column | ||
| * @param cv The input column | ||
| */ | ||
| public static void assertColumnsAreEqual(ColumnView expect, ColumnView cv) { |
There was a problem hiding this comment.
Nit: name "expected" to be consistent with other methods.
Suggested change
| public static void assertColumnsAreEqual(ColumnView expect, ColumnView cv) { | |
| public static void assertColumnsAreEqual(ColumnView expected, ColumnView cv) { |
|
@gpucibot merge |
|
rerun tests |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableTest has a number of dependencies, e.g.: Parquet, Hadoop, etc., that make it less ideal to be used in an external project. This moves the column and table assertion methods to a separate AssertUtils utility class that avoids the extra dependencies.