Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Java classloader to find test resources #9760

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Use Java classloader to find test resources #9760

merged 2 commits into from
Nov 30, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Nov 23, 2021

Updates the Java tests to use the classloader to locate test files rather than reaching directly into the source directory.

@jlowe jlowe added tests Unit testing for project Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 23, 2021
@jlowe jlowe self-assigned this Nov 23, 2021
@jlowe jlowe requested a review from a team as a code owner November 23, 2021 13:48
gerashegalov
gerashegalov approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nits

java/src/test/java/ai/rapids/cudf/TestUtils.java Outdated Show resolved Hide resolved
java/src/test/java/ai/rapids/cudf/TestUtils.java Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 23, 2021 •
edited
Loading

Codecov Report

Merging #9760 (d9b94ec) into branch-22.02 (967a333) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head d9b94ec differs from pull request most recent head f2b0c59. Consider uploading reports for the commit f2b0c59 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9760      +/-   ##
================================================
- Coverage         10.49%   10.44%   -0.05%     
================================================
  Files               119      119              
  Lines             20305    19945     -360     
================================================
- Hits               2130     2083      -47     
+ Misses            18175    17862     -313
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/custreamz/custreamz/tests/conftest.py 71.42% <0.00%> (-7.15%) ⬇️
python/custreamz/custreamz/tests/test_kafka.py 35.71% <0.00%> (-7.15%) ⬇️
...ython/custreamz/custreamz/tests/test_dataframes.py 96.97% <0.00%> (-2.42%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85df759...f2b0c59. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Nov 23, 2021

rerun tests

3 similar comments
@jlowe
Copy link
Member Author

jlowe commented Nov 29, 2021

rerun tests

@jlowe
Copy link
Member Author

jlowe commented Nov 30, 2021

rerun tests

@jlowe
Copy link
Member Author

jlowe commented Nov 30, 2021

rerun tests

@jlowe
Copy link
Member Author

jlowe commented Nov 30, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1db05c9 into rapidsai:branch-22.02 Nov 30, 2021
@jlowe jlowe deleted the jni-test-paths branch November 30, 2021 17:46
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerashegalov gerashegalov gerashegalov approved these changes

Assignees

@jlowe jlowe

Labels
4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlowe @gerashegalov @vyasr