-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix make_empty_scalar_like on list_type #9759
Merged
rapids-bot
merged 2 commits into
rapidsai:branch-22.02
from
sperlingxx:fix_make_empty_scalar
Dec 2, 2021
Merged
Fix make_empty_scalar_like on list_type #9759
rapids-bot
merged 2 commits into
rapidsai:branch-22.02
from
sperlingxx:fix_make_empty_scalar
Dec 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <[email protected]>
sperlingxx
added
3 - Ready for Review
Ready for review by team
non-breaking
Non-breaking change
bug
Something isn't working
labels
Nov 23, 2021
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9759 +/- ##
================================================
- Coverage 10.49% 10.12% -0.37%
================================================
Files 119 119
Lines 20305 21248 +943
================================================
+ Hits 2130 2151 +21
- Misses 18175 19097 +922
Continue to review full report at Codecov.
|
rerun tests |
ttnghia
approved these changes
Nov 24, 2021
devavret
approved these changes
Nov 24, 2021
rerun tests |
@gpucibot merge |
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
bug
Something isn't working
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9758
In
make_empty_scalar_like
, we create list scalar with the list column itself, which is wrong. The correct way is with the child of list column.