Update DEFAULT_CUDA_VER in ci/cpu/prebuild.sh
#9749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we only do `11.5` builds for RAPIDS, the `DEFAULT_CUDA_VER` variable in `ci/cpu/prebuild.sh` should be set to `11.5` so that the rest of the logic in the file works correctly.
ajschmidt8
added
improvement
bdice
approved these changes
Nov 22, 2021
|
@ajschmidt8 This changeset looks fine but does it need to target 21.12? cc: @beckernick |
jjacobelli
approved these changes
Nov 22, 2021
|
Yep, this should target 21.12 |
|
rerun tests |
1 similar comment
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9749 +/- ##
================================================
- Coverage 10.79% 10.61% -0.18%
================================================
Files 116 118 +2
Lines 18869 20072 +1203
================================================
+ Hits 2036 2130 +94
- Misses 16833 17942 +1109
Continue to review full report at Codecov.
|
|
rerun tests |
|
The CI failures are unrelated to this PR. admin merging to unblock some things downstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we only do
11.5builds for RAPIDS, theDEFAULT_CUDA_VERvariable inci/cpu/prebuild.shshould be set to11.5so that the rest of the logic in the file works correctly.