Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake and conda to 22.02 #9746

Merged
merged 4 commits into from
Dec 2, 2021

Conversation

devavret
Copy link
Contributor

Changes related to update to 22.02 in one conda environment recipe (only 11.5) was missed. This adds that.
Also makes project version changes in cmake related to update from 21.12 to 22.02.

@devavret devavret requested review from a team as code owners November 22, 2021 06:48
@github-actions github-actions bot added CMake CMake build issue conda libcudf Affects libcudf (C++/CUDA) code. labels Nov 22, 2021
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update ci/release/update-version.sh to reflect the new CMake code layout that caused the script to miss these

@github-actions github-actions bot added gpuCI and removed conda labels Nov 22, 2021
@devavret devavret added bug Something isn't working conda non-breaking Non-breaking change and removed gpuCI labels Nov 22, 2021
@devavret
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #9746 (21ec1d0) into branch-22.02 (967a333) will decrease coverage by 0.01%.
The diff coverage is 9.24%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9746      +/-   ##
================================================
- Coverage         10.49%   10.47%   -0.02%     
================================================
  Files               119      119              
  Lines             20305    20369      +64     
================================================
+ Hits               2130     2133       +3     
- Misses            18175    18236      +61     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/csv.py 96.00% <100.00%> (+0.10%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582cc6e...21ec1d0. Read the comment docs.

@devavret
Copy link
Contributor Author

rerun tests

@robertmaynard
Copy link
Contributor

This needs to have latest 22.02 merged in since the failing JIT test issue has been solved

@trxcllnt
Copy link
Contributor

trxcllnt commented Dec 2, 2021

rerun tests

@github-actions github-actions bot added gpuCI and removed conda labels Dec 2, 2021
@devavret
Copy link
Contributor Author

devavret commented Dec 2, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0c08543 into rapidsai:branch-22.02 Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants