Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out-of-bounds memory write in decimal128-to-string conversion #9740

Merged
merged 2 commits into from
Nov 22, 2021

Conversation

davidwendt
Copy link
Contributor

This fixes an error found in a memcheck test referenced here: https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-gpu-test/CUDA=11.5,GPU_LABEL=cuda115,LINUX_VER=centos7,PYTHON=3.8/5082/

This also disables the FixedPointStringConversionOperator which fails on a Debug build and may be a bug in std::string.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Nov 19, 2021
@davidwendt davidwendt self-assigned this Nov 19, 2021
@davidwendt davidwendt requested a review from a team as a code owner November 19, 2021 22:26
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #9740 (912f891) into branch-22.02 (967a333) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 912f891 differs from pull request most recent head 4b25af5. Consider uploading reports for the commit 4b25af5 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9740      +/-   ##
================================================
- Coverage         10.49%   10.47%   -0.02%     
================================================
  Files               119      119              
  Lines             20305    20335      +30     
================================================
  Hits               2130     2130              
- Misses            18175    18205      +30     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9ea2b...4b25af5. Read the comment docs.

Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@codereport
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ebeb202 into rapidsai:branch-22.02 Nov 22, 2021
@davidwendt davidwendt deleted the bug-d128-to-string branch November 22, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants