Add sample JNI API #9728
Merged
Add sample JNI API #9728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Signed-off-by: Chong Gao <[email protected]>
res-life
force-pushed
the
sample_perf
branch
from
cdc5952 to
3b37f06
Compare
firestarman
reviewed
Nov 19, 2021
Signed-off-by: Chong Gao <[email protected]>
wjxiz1992
reviewed
Nov 19, 2021
| @@ -2743,6 +2745,19 @@ public static Table fromPackedTable(ByteBuffer metadata, DeviceMemoryBuffer data | |||
| return result; | |||
| } | |||
|
|
|||
| /** | |||
| * Gather `n` samples from table randomly | |||
| * The output is not same with CPU Sample exec, but this is faster. | |||
There was a problem hiding this comment.
Suggested change
| * The output is not same with CPU Sample exec, but this is faster. | |
| * The output is not the same as what CPU Sample Exec produces, but this is faster. |
firestarman
reviewed
Nov 19, 2021
Signed-off-by: Chong Gao <[email protected]>
revans2
requested changes
Nov 19, 2021
added 2 commits
November 22, 2021 19:45
Signed-off-by: Chong Gao <[email protected]>
|
@revans2 Please help to review. |
revans2
approved these changes
Dec 1, 2021
|
ok to test |
1 similar comment
|
ok to test |
Signed-off-by: Chong Gao <[email protected]>
|
ok to test |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9728 +/- ##
===============================================
Coverage ? 10.47%
===============================================
Files ? 119
Lines ? 20368
Branches ? 0
===============================================
Hits ? 2133
Misses ? 18235
Partials ? 0 Continue to review full report at Codecov.
|
revans2
approved these changes
Dec 2, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sample JNI
Signed-off-by: Chong Gao [email protected]