Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cmake format script #9723

Merged
merged 3 commits into from
Nov 20, 2021
Merged

Improve cmake format script #9723

merged 3 commits into from
Nov 20, 2021

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 18, 2021

This PR ports some improvements from rapidsai/rmm#913.

@vyasr vyasr added 3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 18, 2021
@vyasr vyasr requested a review from robertmaynard November 18, 2021 21:15
@vyasr vyasr self-assigned this Nov 18, 2021
@vyasr vyasr requested a review from a team as a code owner November 18, 2021 21:15
@vyasr vyasr requested a review from hyperbolic2346 November 18, 2021 21:15
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. and removed CMake CMake build issue labels Nov 18, 2021
@vyasr
Copy link
Contributor Author

vyasr commented Nov 19, 2021

rerun tests

@codecov
Copy link

codecov bot commented Nov 19, 2021 •
edited
Loading

Codecov Report

Merging #9723 (cd1036a) into branch-22.02 (d623c93) will decrease coverage by 1.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-22.02   #9723      +/-   ##
===============================================
- Coverage         10.61%   9.55%   -1.06%     
===============================================
  Files               118     119       +1     
  Lines             20075   22283    +2208     
===============================================
  Hits               2130    2130              
- Misses            17945   20153    +2208
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/decimal.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/df_protocol.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 0.00% <ø> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/join/__init__.py 0.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc82b1d...cd1036a. Read the comment docs.

@vyasr
Copy link
Contributor Author

vyasr commented Nov 19, 2021

rerun tests

@vyasr
Copy link
Contributor Author

vyasr commented Nov 20, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 65af9a3 into rapidsai:branch-22.02 Nov 20, 2021
@vyasr vyasr deleted the linting/improve_cmake_format_script branch January 14, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @robertmaynard @bdice @ttnghia