-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regex non-multiline EOL/$ matching strings ending with a new-line #9715
Merged
rapids-bot
merged 3 commits into
rapidsai:branch-22.02
from
davidwendt:bug-eol-newline-wec
Nov 19, 2021
Merged
Fix regex non-multiline EOL/$ matching strings ending with a new-line #9715
rapids-bot
merged 3 commits into
rapidsai:branch-22.02
from
davidwendt:bug-eol-newline-wec
Nov 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Something isn't working
3 - Ready for Review
Ready for review by team
libcudf
Affects libcudf (C++/CUDA) code.
strings
strings issues (C++ and Python)
non-breaking
Non-breaking change
labels
Nov 17, 2021
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9715 +/- ##
===============================================
Coverage ? 10.60%
===============================================
Files ? 118
Lines ? 20082
Branches ? 0
===============================================
Hits ? 2130
Misses ? 17952
Partials ? 0 Continue to review full report at Codecov.
|
cwharris
approved these changes
Nov 17, 2021
vuule
approved these changes
Nov 17, 2021
vuule
added
4 - Needs cuDF (Python) Reviewer
and removed
3 - Ready for Review
Ready for review by team
labels
Nov 18, 2021
skirui-source
approved these changes
Nov 18, 2021
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 - Needs Review
Waiting for reviewer to review or respond
bug
Something isn't working
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
strings
strings issues (C++ and Python)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9620
Fixes an edge case described in https://docs.python.org/3/library/re.html#re.MULTILINE
where the '$' EOL regex pattern character (without
MULTILINE
set) should match at the very end of a string and also just before the end of the string if the end of that string contains a new-line.