Parquet decimal128 support #9706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 20, 2021 02:07
github-actions
bot
added
conda
Python
devavret
commented
Nov 16, 2021
| @@ -176,7 +176,8 @@ __global__ void __launch_bounds__(block_size) | |||
| } | |||
| } | |||
| dtype = s->col.physical_type; | |||
| dtype_len = (dtype == INT96) ? 12 | |||
| dtype_len = (dtype == FIXED_LEN_BYTE_ARRAY) ? 16 | |||
There was a problem hiding this comment.
This should probably also check if col type is decimal128
| expected_metadata.column_metadata[1].set_name("decimal64s").set_decimal_precision(10); | ||
| expected_metadata.column_metadata[2].set_name("decimal128s").set_decimal_precision(10); | ||
|
|
||
| auto filepath = ("MultiColumn.parquet"); |
There was a problem hiding this comment.
This test fails because the reader doesn't support reading decimal128 but the file created by this test can be read with pyarrow to confirm that the writing is correct.
ajschmidt8
approved these changes
Nov 17, 2021
|
superseded by #9765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.