Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix null handling when boolean dtype is passed #9691

Merged
merged 1 commit into from
Nov 16, 2021
Merged

[REVIEW] Fix null handling when boolean dtype is passed #9691

merged 1 commit into from
Nov 16, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #9642

This PR fixes issue where null values being treated as False when boolean dtype was being passed to the Series constructor.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Nov 15, 2021
@galipremsagar galipremsagar self-assigned this Nov 15, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner November 15, 2021 21:32
@galipremsagar galipremsagar requested a review from shwina November 15, 2021 21:32
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Nov 16, 2021
@galipremsagar
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Nov 16, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@31f92d7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #9691   +/-   ##
===============================================
  Coverage                ?   10.61%           
===============================================
  Files                   ?      118           
  Lines                   ?    20075           
  Branches                ?        0           
===============================================
  Hits                    ?     2130           
  Misses                  ?    17945           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31f92d7...c4e51e3. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c3bcc8d into rapidsai:branch-22.02 Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu rgsl888prabhu is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] dtype="boolean" ignores nulls
2 participants
@galipremsagar @shwina