[gpuCI] Forward-merge branch-21.12 to branch-22.02 [skip gpuci] #9671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes implementations of `__sizeof__` from cudf classes. Previously, `__sizeof__` was overridden to return the total GPU memory usage, but this is inconsistent with the standard Python semantics of this function and should be removed. The appropriate way to query for total GPU memory usage is via the `memory_usage` function, which is now standardized across various objects. The sizeof dispatch for dask is set to use `memory_usage` as well to avoid any breakage here. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Charles Blackmon-Luca (https://github.com/charlesbluca) - Mads R. B. Kristensen (https://github.com/madsbk) URL: #9544
This PR is a minimal set of changes that appear to be required to maximize inlining of code involved in AST-based expression evaluation. Specifically, applying the `__forceinline__` qualifier to the type dispatcher results in a significant performance improvement when nullable data is passed through the AST evaluator. I observe roughly a 2x performance improvement with a negligible increase in compilation time. Note that the specific improvements appear to be heavily dependent on the architecture being tested on. Interestingly, removing the `__forceinline__` on the `evaluate` methods results in performance regressing back to its original values despite them being defined inline, an unexpected result. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) - Jake Hemstad (https://github.com/jrhemstad) URL: #9530
GPUtester
requested review from
devavret,
ttnghia,
marlenezw and
skirui-source
|
SUCCESS - forward-merge complete. |
github-actions
bot
added
Python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-21.12that creates a PR to keepbranch-22.02up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.