Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cudf's concurrent_ordered_map with cuco::static_map in semi/anti joins #9666

Merged
merged 14 commits into from
Jan 5, 2022
Merged
Prev Previous commit
Next Next commit
Fully functional implementation using cuco.
vyasr committed Nov 23, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit e0d947ced3349bdeac121e7fcba544deee4c7984
15 changes: 8 additions & 7 deletions cpp/src/join/semi_join.cu
Original file line number Diff line number Diff line change
@@ -115,13 +115,14 @@ std::unique_ptr<rmm::device_uvector<cudf::size_type>> left_semi_anti_join(
hash_table.insert(iter, iter + right_num_rows, hash_build, equality_build);
// hash_table.insert(iter, iter + right_num_rows, hash_build, equality_build, stream.value());
} else {
CUDF_FAIL("Not supported yet!");
// thrust::counting_iterator<size_type> stencil(0);
// auto const row_bitmask = cudf::detail::bitmask_and(right_flattened_keys, stream);;
// row_is_valid pred{static_cast<bitmask_type const*>(row_bitmask.data())};
//
//// insert valid rows
//// TODO: This needs to be implemented still for static_map, it only exists for multimap.
thrust::counting_iterator<size_type> stencil(0);
auto const row_bitmask = cudf::detail::bitmask_and(right_flattened_keys, stream);
;
row_is_valid pred{static_cast<bitmask_type const*>(row_bitmask.data())};

// insert valid rows
// TODO: Need to enable a stream argument in cuco.
hash_table.insert_if(iter, iter + right_num_rows, stencil, pred, hash_build, equality_build);
// hash_table.insert_if(iter, iter + right_num_rows, stencil, pred, hash_build, equality_build,
// stream.value());
}