Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Some improvements to parse_decimal function and bindings for is_fixed_point #9658

Merged
merged 4 commits into from
Nov 16, 2021
Merged

[Java] Some improvements to parse_decimal function and bindings for is_fixed_point #9658

merged 4 commits into from
Nov 16, 2021

Conversation

razajafri
Copy link
Contributor

@razajafri razajafri commented Nov 11, 2021 •
edited
Loading

This PR adds Java bindings for is_fixed_point

@razajafri razajafri added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 11, 2021
@razajafri razajafri self-assigned this Nov 11, 2021
@razajafri razajafri requested review from a team as code owners November 11, 2021 05:06
@github-actions github-actions bot added Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Nov 11, 2021
@razajafri razajafri changed the title String to Fixed-point conversion [Java] String to Fixed-point conversion Nov 11, 2021
@razajafri razajafri changed the title [Java] String to Fixed-point conversion [Java] Some improvements to parse_decimal function and bindings for is_fixed_point Nov 11, 2021
@razajafri
Copy link
Contributor Author

@revans2 most of what we talked about was implemented already. PTAL and let me know if I missed anything

@razajafri razajafri mentioned this pull request Nov 11, 2021
Merged
@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@4dd8293). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #9658   +/-   ##
===============================================
  Coverage                ?   10.61%           
===============================================
  Files                   ?      118           
  Lines                   ?    20073           
  Branches                ?        0           
===============================================
  Hits                    ?     2130           
  Misses                  ?    17943           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd8293...f0d7898. Read the comment docs.

@razajafri razajafri changed the base branch from branch-21.12 to branch-22.02 November 12, 2021 18:07
@razajafri
Copy link
Contributor Author

@gpucibot merge

@razajafri razajafri requested a review from davidwendt November 14, 2021 21:09
@ttnghia
Copy link
Contributor

ttnghia commented Nov 14, 2021

This PR is no longer a libcudf PR and just requires java codeowner approval.

revans2
revans2 approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a documentation nit

java/src/main/java/ai/rapids/cudf/ColumnView.java Show resolved Hide resolved
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 15, 2021
@razajafri
Copy link
Contributor Author

rerun tests

@razajafri
Copy link
Contributor Author

rerun tests

@razajafri
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7e4a985 into rapidsai:branch-22.02 Nov 16, 2021
@razajafri razajafri deleted the CUDF-fixed-point branch November 16, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@ttnghia ttnghia ttnghia approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@revans2 revans2 revans2 approved these changes

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu rgsl888prabhu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@razajafri razajafri

Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@razajafri @ttnghia @revans2 @hyperbolic2346 @davidwendt