[REVIEW] Change minimum pin of cupy
#9636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
improvement
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9636 +/- ##
================================================
- Coverage 10.79% 10.66% -0.13%
================================================
Files 116 117 +1
Lines 18869 19832 +963
================================================
+ Hits 2036 2115 +79
- Misses 16833 17717 +884
Continue to review full report at Codecov.
|
ajschmidt8
approved these changes
Nov 9, 2021
ajschmidt8
requested changes
Nov 9, 2021
There was a problem hiding this comment.
Let's hold off on merging this while I debug some things from rapidsai/integration#388. Some of the failures there are expected, but some of them aren't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates minimum version pinning of
cupythat is compatible with CEC.