Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set RMM pool to a fixed size in JNI #9583

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Set RMM pool to a fixed size in JNI #9583

merged 3 commits into from
Nov 3, 2021

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Nov 2, 2021

For spark user cases, we want to have a fixed-size pool instead of growing it, to avoid unnecessary fragmentation, and to simply the configuration.

@rongou rongou added 3 - Ready for Review Ready for review by team RMM Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 2, 2021
@rongou rongou requested review from jlowe and revans2 November 2, 2021 21:41
@rongou rongou self-assigned this Nov 2, 2021
@rongou rongou requested a review from a team as a code owner November 2, 2021 21:41
@rongou rongou mentioned this pull request Nov 3, 2021
Closed
@codecov
Copy link

codecov bot commented Nov 3, 2021 •
edited
Loading

Codecov Report

Merging #9583 (97cccce) into branch-21.12 (ab4bfaa) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9583      +/-   ##
================================================
- Coverage         10.79%   10.66%   -0.13%     
================================================
  Files               116      117       +1     
  Lines             18869    19736     +867     
================================================
+ Hits               2036     2104      +68     
- Misses            16833    17632     +799
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcf90f...97cccce. Read the comment docs.

@rongou
Copy link
Contributor Author

rongou commented Nov 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4dd8293 into rapidsai:branch-21.12 Nov 3, 2021
@rongou rongou mentioned this pull request Nov 3, 2021
Merged
@abellina abellina mentioned this pull request Nov 5, 2021
Closed
@rongou rongou deleted the no-max-pool-size branch November 23, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@revans2 revans2 Awaiting requested review from revans2

Assignees

@rongou rongou

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rongou @jlowe