-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceil/floor for DatetimeIndex
#9554
ceil/floor for DatetimeIndex
#9554
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9554 +/- ##
===============================================
Coverage ? 10.60%
===============================================
Files ? 118
Lines ? 20090
Branches ? 0
===============================================
Hits ? 2130
Misses ? 17960
Partials ? 0 Continue to review full report at Codecov.
|
Based on a slack conversation with Ashwin: The
|
My 2c is yes. I realize at this point that it's more effort to deprecate these APIs than just to continue supporting them. However, compatibility goes both ways: if users want to switch out Pandas with cuDF with minimal effort, doing the same the other way should also be minimal effort, and enabling APIs like these makes that more difficult. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the history but I imagined back in the days when UDFs where not handy, these functions are very useful rounding columns. Today with improvements in UDF it can be done like df.apply(lambda row: math.ceil(row['a']), axis=1)
. I see why we don't want to maintain two approach for the same goal.
@shwina should I then add Deprecation warning or no? |
Yes please :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion, else lgtm!
@gpucibot merge |
Follow-up to #9571 where we add
ceil
andfloor
support forSeries
.Here we add
ceil
andfloor
support toDatetimeIndex
class. This PR is dependent on #9571 getting merged first since it assumes thelibcudf
implementation forfloor
exists.