Fix several test and benchmark issues related to bitmask allocations. #9521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a crash when trying to use the data coming out of
create_random_table
. The code was not generating buffers padded to 64 bytes, which was expected by the column utilities code. I made several changes to address this:Fix the core issue itself: make the bitmask buffers coming out of create_random_table conform to the cudf standard.
Changed
bitmask_to_host
in column_utilites.cu to only return the number of bitmask words necessary to represent the number of rows in the column. Previously it was returning all the padding words as well, which was meaningless.Fixed an issue in test code that wasn't using
cudf::test::validate_host_masks
when it should have been.