Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several test and benchmark issues related to bitmask allocations. #9521

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

nvdbaranec
Copy link
Contributor

I encountered a crash when trying to use the data coming out of create_random_table. The code was not generating buffers padded to 64 bytes, which was expected by the column utilities code. I made several changes to address this:

  • Fix the core issue itself: make the bitmask buffers coming out of create_random_table conform to the cudf standard.

  • Changed bitmask_to_host in column_utilites.cu to only return the number of bitmask words necessary to represent the number of rows in the column. Previously it was returning all the padding words as well, which was meaningless.

  • Fixed an issue in test code that wasn't using cudf::test::validate_host_masks when it should have been.

@nvdbaranec nvdbaranec added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Oct 25, 2021
@nvdbaranec nvdbaranec requested a review from a team as a code owner October 25, 2021 23:17
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #9521 (85c264b) into branch-21.12 (ab4bfaa) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9521      +/-   ##
================================================
- Coverage         10.79%   10.67%   -0.12%     
================================================
  Files               116      117       +1     
  Lines             18869    19714     +845     
================================================
+ Hits               2036     2104      +68     
- Misses            16833    17610     +777     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/timedelta.py 0.00% <0.00%> (ø)
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d6ecd1...85c264b. Read the comment docs.

@nvdbaranec
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1c9a92b into rapidsai:branch-21.12 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants