-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on six. #9495
Conversation
|
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9495 +/- ##
================================================
- Coverage 10.79% 10.66% -0.13%
================================================
Files 116 117 +1
Lines 18869 19727 +858
================================================
+ Hits 2036 2104 +68
- Misses 16833 17623 +790
Continue to review full report at Codecov.
|
The test failure will be resolved once #9508 is merged and CI is re-triggered. |
@gpucibot rerun tests |
1 similar comment
@gpucibot rerun tests |
Tests have failed on random download errors twice. I am re-running again. This is ready to merge once CI gets it together. 🙃 |
rerun tests |
@bdice for future reference, the request to rerun test does not go through |
@gpucibot merge |
I noticed while working on #9448 that we
import six
but it doesn't appear to be a dependency of cuDF. Since that package is meant for Python 2 compatibility and we do not support Python 2, I think it can be removed.six
is probably being installed as a transitive dependency of some dependency of cuDF, if I were to guess, otherwise I'd think tests would fail.Note: the
queryutils.py
module containing these lines may be somewhat outdated. The module is not covered by tests from 21.08 through 21.12, but was covered by tests in 21.06. It is currently only used in a couple places, which may deserve some cleanup: https://github.com/rapidsai/cudf/search?q=queryutils