Match conda pinnings for style checks (revert part of #9412, #9433). #9490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9490 +/- ##
================================================
- Coverage 10.79% 10.67% -0.12%
================================================
Files 116 117 +1
Lines 18869 19714 +845
================================================
+ Hits 2036 2104 +68
- Misses 16833 17610 +777
Continue to review full report at Codecov.
|
ajschmidt8
approved these changes
Oct 21, 2021
vyasr
approved these changes
Oct 21, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes in #9412 and #9433 may lead to conflicts in VSCode / rapids-compose behavior for many developers. I am closing my PRs #9448 and #9450 for the same reason. See #9450 (comment) for details.
This PR reverts the problematic parts of #9412 and #9433, and makes the pre-commit configuration and the conda environment pinnings consistent.
Tagging @vyasr @galipremsagar @ajschmidt8 for awareness.