Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document invalid regex patterns as undefined behavior #9473

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Oct 19, 2021

Closes #9463
Closes #9434

This adds a small section to the Regex Features page describing invalid regex patterns may result in undefined behavior. The list here includes current issues as well as ones opened in the past:
#3732, #8832, #5234, #4746, #3725

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) non-breaking Non-breaking change labels Oct 19, 2021
@davidwendt davidwendt self-assigned this Oct 19, 2021
@davidwendt davidwendt requested a review from a team as a code owner October 19, 2021 17:23
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f41e05f into rapidsai:branch-21.12 Oct 29, 2021
@davidwendt davidwendt deleted the docs-regex-invalid-ub branch October 29, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
4 participants