Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyarrow import in dask_cudf.io.parquet #9429

Merged

Conversation

charlesbluca
Copy link
Member

Small follow up to #9314, which implements my review comments and removes a seemingly unnecessary import of pyarrow.

cc @rjzamora @jakirkham

@charlesbluca charlesbluca requested a review from a team as a code owner October 13, 2021 13:39
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 13, 2021
@charlesbluca charlesbluca added 3 - Ready for Review Ready for review by team dask-cudf improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Oct 13, 2021
@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar
Copy link
Contributor

rerun tests

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #9429 (24e0466) into branch-21.12 (ab4bfaa) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 24e0466 differs from pull request most recent head eda1a87. Consider uploading reports for the commit eda1a87 to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##           branch-21.12    #9429    +/-   ##
==============================================
  Coverage         10.79%   10.79%            
==============================================
  Files               116      117     +1     
  Lines             18869    19434   +565     
==============================================
+ Hits               2036     2097    +61     
- Misses            16833    17337   +504     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/strings/__init__.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/sorting.py 93.52% <0.00%> (-0.60%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9806ff...eda1a87. Read the comment docs.

@galipremsagar
Copy link
Contributor

rerun tests

1 similar comment
@galipremsagar
Copy link
Contributor

rerun tests

@charlesbluca
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 690cb39 into rapidsai:branch-21.12 Oct 14, 2021
@charlesbluca charlesbluca deleted the dask-parquet-pa-import branch July 19, 2022 14:26
@vyasr vyasr added dask Dask issue and removed dask-cudf labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants