Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous improvements for UDFs #9422

Merged
merged 11 commits into from
Nov 11, 2021
Merged

Miscellaneous improvements for UDFs #9422

merged 11 commits into from
Nov 11, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Oct 12, 2021 •
edited
Loading

  • Merge func_pdf and func_gdf into a single func.
  • Add support to bitwise logical ops.
  • Use internal set_base_mask api, eliminating deprecation warning.
  • Update df.apply docstrings to match Support Python UDFs written in terms of rows #9343
  • Add (sampled) parametrization ops over mixed dtypes test case

@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 12, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021 •
edited
Loading

Codecov Report

Merging #9422 (b49c702) into branch-21.12 (ab4bfaa) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9422      +/-   ##
================================================
- Coverage         10.79%   10.68%   -0.11%     
================================================
  Files               116      117       +1     
  Lines             18869    19875    +1006     
================================================
+ Hits               2036     2123      +87     
- Misses            16833    17752     +919
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ca7c96...b49c702. Read the comment docs.

@isVoid isVoid self-assigned this Oct 22, 2021
@isVoid isVoid added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Oct 22, 2021
@isVoid isVoid marked this pull request as ready for review October 22, 2021 03:44
@isVoid isVoid requested a review from a team as a code owner October 22, 2021 03:44
@isVoid isVoid requested a review from vyasr October 22, 2021 03:44
brandon-b-miller
brandon-b-miller requested changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise LGTM. Thank you sooooo much for this @isVoid !

@isVoid @brandon-b-miller
Apply suggestions from code review
2a590e9 
Co-authored-by: brandon-b-miller <[email protected]>
vyasr
vyasr requested changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments, looks good overall.

@isVoid isVoid requested a review from vyasr November 3, 2021 18:11
vyasr
vyasr approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isVoid
Copy link
Contributor Author

isVoid commented Nov 11, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9f9a377 into rapidsai:branch-21.12 Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@isVoid isVoid

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isVoid @vyasr @brandon-b-miller