-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Type Metadata to Column Children #9391
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9391 +/- ##
================================================
- Coverage 10.79% 10.61% -0.18%
================================================
Files 116 118 +2
Lines 18869 20073 +1204
================================================
+ Hits 2036 2130 +94
- Misses 16833 17943 +1110
Continue to review full report at Codecov.
|
rerun tests |
rerun tests |
5 similar comments
rerun tests |
rerun tests |
rerun tests |
rerun tests |
rerun tests |
@isVoid is it possible to avoid the deep copy here? (for slicing). |
This PR applies type metadata to column children when the column is slice constructed. This make sure compound type metadata (lists, structs) gets passed on correctly to children.
closes #9177