Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Type Metadata to Column Children #9391

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Oct 6, 2021

This PR applies type metadata to column children when the column is slice constructed. This make sure compound type metadata (lists, structs) gets passed on correctly to children.

closes #9177

@isVoid isVoid requested a review from a team as a code owner October 6, 2021 20:02
@isVoid isVoid requested review from shwina and skirui-source October 6, 2021 20:02
@isVoid isVoid added Python Affects Python cuDF API. bug Something isn't working non-breaking Non-breaking change labels Oct 6, 2021
@isVoid isVoid self-assigned this Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #9391 (04fd26b) into branch-21.12 (ab4bfaa) will decrease coverage by 0.17%.
The diff coverage is n/a.

❗ Current head 04fd26b differs from pull request most recent head 0f97268. Consider uploading reports for the commit 0f97268 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9391      +/-   ##
================================================
- Coverage         10.79%   10.61%   -0.18%     
================================================
  Files               116      118       +2     
  Lines             18869    20073    +1204     
================================================
+ Hits               2036     2130      +94     
- Misses            16833    17943    +1110     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/cut.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f9a377...0f97268. Read the comment docs.

@isVoid isVoid added the 3 - Ready for Review Ready for review by team label Oct 7, 2021
@isVoid
Copy link
Contributor Author

isVoid commented Nov 11, 2021

rerun tests

@isVoid
Copy link
Contributor Author

isVoid commented Nov 11, 2021

rerun tests

5 similar comments
@isVoid
Copy link
Contributor Author

isVoid commented Nov 12, 2021

rerun tests

@jjacobelli
Copy link
Contributor

rerun tests

@jjacobelli
Copy link
Contributor

rerun tests

@jjacobelli
Copy link
Contributor

rerun tests

@isVoid
Copy link
Contributor Author

isVoid commented Nov 15, 2021

rerun tests

@isVoid isVoid added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 16, 2021
@ajschmidt8 ajschmidt8 merged commit 22a2ac9 into rapidsai:branch-21.12 Nov 16, 2021
@karthikeyann
Copy link
Contributor

@isVoid is it possible to avoid the deep copy here? (for slicing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Slice from nested struct type column to_arrow does not retain inner level field names
6 participants