MD5 Python hash API #9390
Merged
MD5 Python hash API #9390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
feature request
isVoid
reviewed
Oct 6, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9390 +/- ##
================================================
- Coverage 10.79% 10.76% -0.03%
================================================
Files 116 116
Lines 18869 19478 +609
================================================
+ Hits 2036 2096 +60
- Misses 16833 17382 +549
Continue to review full report at Codecov.
|
shwina
reviewed
Oct 12, 2021
| "a multi hash-step data point in the hash function being " | ||
| "tested. This string needed to be longer." | ||
| ), | ||
| "All work and no play makes Jack a dull boy", |
shwina
approved these changes
Oct 12, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a public API in cuDF for MD5 hashing, using the parameter
DataFrame.hash_columns(..., method="md5")orSeries.hash_values(..., method="md5"). The default hashing method is MurmurHash3 (method="murmur3"). I also changed the return value ofSeries.hash_valuesto be aSeries, rather than a cupy array.Related to #8641. SHA support will be added in a later PR.