-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable casting to int64, uint64, and double in AST code. #9379
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9379 +/- ##
================================================
+ Coverage 10.79% 10.83% +0.04%
================================================
Files 116 117 +1
Lines 18869 19442 +573
================================================
+ Hits 2036 2106 +70
- Misses 16833 17336 +503
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SFINAE and type traits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add these operators to UnaryOperator.java
:
https://github.com/rapidsai/cudf/blob/branch-21.12/java/src/main/java/ai/rapids/cudf/ast/UnaryOperator.java
Otherwise, looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the Java code was updated as part of this PR to add bindings to these new AST operators, it would be nice to have Java tests to verify those bindings are operating correctly. Happy to do this as a followup if needed.
@jlowe if you don't mind adding the tests separately that would be great. It would be good to get this merged so I can work on some next steps in the AST code. If you don't get around to writing the tests let me know, I can always make the follow-up myself. |
@gpucibot merge |
This PR resolves #8979, adding support for a few casting operators in AST code. These operators can be used to perform operations between columns with mismatched data types without materializing intermediates as new columns.