Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Default Memory Resource for Temporaries in reduction.cpp #9344

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Use Default Memory Resource for Temporaries in reduction.cpp #9344

merged 1 commit into from
Sep 30, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Sep 29, 2021

This PR replaces the memory resource for temporaries in reduction.cpp with default memory resources.

@isVoid isVoid requested a review from a team as a code owner September 29, 2021 22:05
@isVoid isVoid requested review from bdice and mythrocks September 29, 2021 22:05
@isVoid isVoid added libcudf Affects libcudf (C++/CUDA) code. 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 29, 2021
@isVoid isVoid mentioned this pull request Sep 29, 2021
Merged
@isVoid isVoid changed the title Use Default MR for Temporaries in reduction.cpp Use Default Memory Resource for Temporaries in reduction.cpp Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021 •
edited
Loading

Codecov Report

Merging #9344 (2bc526b) into branch-21.12 (ab4bfaa) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 2bc526b differs from pull request most recent head b09067e. Consider uploading reports for the commit b09067e to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9344      +/-   ##
================================================
- Coverage         10.79%   10.77%   -0.02%     
================================================
  Files               116      116              
  Lines             18869    19360     +491     
================================================
+ Hits               2036     2087      +51     
- Misses            16833    17273     +440
Impacted Files Coverage Δ
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/join/_join_helpers.py 0.00% <ø> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/udf/api.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/udf/lowering.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/udf/pipeline.py 0.00% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63f455...b09067e. Read the comment docs.

@isVoid isVoid added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 30, 2021
mythrocks
mythrocks approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isVoid
Copy link
Contributor Author

isVoid commented Sep 30, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ffb3814 into rapidsai:branch-21.12 Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@mythrocks mythrocks mythrocks approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isVoid @bdice @mythrocks @davidwendt