Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpuCI] Forward-merge branch-21.10 to branch-21.12 [skip gpuci] #9342

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

GPUtester
Copy link
Collaborator

Forward-merge triggered by push to branch-21.10 that creates a PR to keep branch-21.12 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

…em (#9277)

* Stop CMake from marking cudf's libcudacxx and thrust includes as system

nvcc automatically adds the CUDA Toolkit system include paths before any
system include paths that CMake adds.

CMake implicitly treats all includes on import targets as 'SYSTEM' includes.

To get the cudacxx shipped with cudf to be picked up by consumers instead of the
version shipped with the CUDA Toolkit we need to make sure it is a non-SYSTEM
include on the CMake side.

* Clarify comment
This makes sure that the `arrow_[shared|static]`, and
`arrow_cuda_[shared|static]` exist in the build directory
cudf-config.cmake as they exist in the install version.
@GPUtester GPUtester requested a review from a team as a code owner September 29, 2021 20:35
@GPUtester GPUtester merged commit e63f455 into branch-21.12 Sep 29, 2021
@GPUtester
Copy link
Collaborator Author

SUCCESS - forward-merge complete.

@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants