Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some unused variable warnings in libcudf #9326

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Fix some unused variable warnings in libcudf #9326

merged 2 commits into from
Sep 29, 2021

Conversation

davidwendt
Copy link
Contributor

Some unused variable warnings are appearing in 11.4 builds from recent PR merges.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 28, 2021
@davidwendt davidwendt self-assigned this Sep 28, 2021
@davidwendt davidwendt marked this pull request as ready for review September 28, 2021 18:53
@davidwendt davidwendt requested a review from a team as a code owner September 28, 2021 18:53
@davidwendt
Copy link
Contributor Author

rerun tests

ttnghia
ttnghia approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rerun tests.

@ttnghia
Copy link
Contributor

ttnghia commented Sep 28, 2021

Rerun tests.

@davidwendt
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #9326 (fe4348d) into branch-21.12 (ab4bfaa) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head fe4348d differs from pull request most recent head b8fc85b. Consider uploading reports for the commit b8fc85b to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9326      +/-   ##
================================================
+ Coverage         10.79%   10.81%   +0.02%     
================================================
  Files               116      116              
  Lines             18869    18873       +4     
================================================
+ Hits               2036     2042       +6     
+ Misses            16833    16831       -2
Impacted Files Coverage Δ
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/backends.py 82.31% <0.00%> (+3.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6484e2a...b8fc85b. Read the comment docs.

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fdb9e3b into rapidsai:branch-21.12 Sep 29, 2021
@davidwendt davidwendt deleted the fix-unused-var-warnings branch September 29, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@vyasr vyasr vyasr approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @ttnghia @vyasr