Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Pin transformers to <=4.10.3 #9322

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

galipremsagar
Copy link
Contributor

There is a importError in latest transformers release, hence pinning the max transformers version.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Sep 28, 2021
@galipremsagar galipremsagar self-assigned this Sep 28, 2021
@galipremsagar galipremsagar requested review from a team as code owners September 28, 2021 14:10
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Sep 28, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 28, 2021
@ajschmidt8
Copy link
Member

rapidsai/integration#362 is merged. We just need to wait until the new integration packages are published and then we need to rebuild the CI containers so they use the latest integration packages and then we can rerun the tests here and everything should pass.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #9322 (56b4538) into branch-21.10 (0b89459) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 56b4538 differs from pull request most recent head 6a9987a. Consider uploading reports for the commit 6a9987a to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           branch-21.10    #9322   +/-   ##
=============================================
  Coverage         10.80%   10.80%           
=============================================
  Files               116      116           
  Lines             19321    19318    -3     
=============================================
  Hits               2087     2087           
+ Misses            17234    17231    -3     
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b89459...6a9987a. Read the comment docs.

@ajschmidt8
Copy link
Member

rerun tests

1 similar comment
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

@ajschmidt8
Copy link
Member

CI has passed. merging.

@ajschmidt8 ajschmidt8 merged commit 52e53f0 into rapidsai:branch-21.10 Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants