Pin mypy in .pre-commit-config.yaml to match conda environment pinning. #9300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
3 - Ready for Review
shwina
approved these changes
Sep 24, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9300 +/- ##
================================================
+ Coverage 10.79% 10.83% +0.04%
================================================
Files 116 116
Lines 18869 19255 +386
================================================
+ Hits 2036 2087 +51
- Misses 16833 17168 +335
Continue to review full report at Codecov.
|
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
I made a small mistake in PR #9300. I missed the setting `pass_filenames: false`, which causes mypy to fail with an error about duplicate module names. This PR adds that setting back and fixes the error. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #9349
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
Following up on #9412, this PR updates some pre-commit hook URLs that have moved. This now uses the canonical URLs instead of a redirect. Note: As of PR #9412, the pre-commit configuration is used for style checks on CI. The versions used by pre-commit are in a separate virtual environment from any linters/formatters in the user's local/conda environment. I also updated the pinned versions of `flake8`, `pydocstyle`, and `isort`, which are more than a year old. The updates to these hooks do not require any changes to the code for compliance, and I do not anticipate any PR conflicts. Users of pre-commit will be automatically upgraded next time pre-commit runs. I did not upgrade `black` or `mypy`: - Upgrading `black` to the latest version introduces a relatively large number of small formatting changes and should be handled in a separate PR. - Upgrading `mypy` to the latest version introduces an issue I reported in #9300 and should be handled in a separate PR. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Ashwin Srinath (https://github.com/shwina) URL: #9433
This was referenced Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently mypy set as is a "local" hook in pre-commit, meaning that it uses
mypyfrom the user's environment. I have mypy 0.910 installed (released Jun 22, 2021) locally and it fails with the following error:The conda environment pinning is currently 0.782 (released Jun 23, 2020). Newer versions of mypy (around 0.900) have substantial behavior changes, so my newer version throws errors that are not seen in the older mypy that is pinned for CI checks.
This PR changes the behavior of
.pre-commit-config.ymlto use mypy from a mirror repository, at the same pinning used in the conda environment, instead of the local executable.