Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed_point cudf::groupby for mean aggregation #9296

Merged
merged 1 commit into from
Sep 24, 2021
Merged

fixed_point cudf::groupby for mean aggregation #9296

merged 1 commit into from
Sep 24, 2021

Conversation

codereport
Copy link
Contributor

This fixes #9224.

fixed_point groupby with mean shouldn't use double as the result type, it should use fixed_point. This PR fixes that.

@codereport codereport added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond non-breaking Non-breaking change labels Sep 24, 2021
@codereport codereport requested a review from a team as a code owner September 24, 2021 06:12
@codereport codereport self-assigned this Sep 24, 2021
@codereport codereport requested review from cwharris, rgsl888prabhu and jrhemstad and removed request for cwharris September 24, 2021 06:12
@codecov
Copy link

codecov bot commented Sep 24, 2021 •
edited
Loading

Codecov Report

Merging #9296 (8f3dfd6) into branch-21.10 (3ee3ecf) will decrease coverage by 0.05%.
The diff coverage is 12.05%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #9296      +/-   ##
================================================
- Coverage         10.85%   10.80%   -0.06%     
================================================
  Files               115      116       +1     
  Lines             19158    19321     +163     
================================================
+ Hits               2080     2087       +7     
- Misses            17078    17234     +156
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/text.py 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c431650...8f3dfd6. Read the comment docs.

@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Sep 24, 2021
@codereport
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ad76ed1 into rapidsai:branch-21.10 Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@ttnghia ttnghia ttnghia approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad

Assignees

@codereport codereport

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Mean Aggregation on decimal column yields a float64 column as result
3 participants
@codereport @ttnghia @rgsl888prabhu