Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add shallow hash function and shallow equality comparison for column_view (#9185)" #9283

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Revert "Add shallow hash function and shallow equality comparison for column_view (#9185)" #9283

merged 1 commit into from
Sep 23, 2021

Conversation

karthikeyann
Copy link
Contributor

Reverts #9185

More details on PR #9185

@karthikeyann karthikeyann added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. 5 - DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Sep 23, 2021
@karthikeyann karthikeyann requested a review from a team as a code owner September 23, 2021 14:34
@github-actions github-actions bot added the CMake CMake build issue label Sep 23, 2021
@karthikeyann karthikeyann changed the title Revert "Add shallow hash function and shallow equality comparison for column_view" Revert "Add shallow hash function and shallow equality comparison for column_view" (#9185) Sep 23, 2021
@karthikeyann karthikeyann changed the title Revert "Add shallow hash function and shallow equality comparison for column_view" (#9185) Revert "Add shallow hash function and shallow equality comparison for column_view (#9185)" Sep 23, 2021
devavret
devavret approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@devavret devavret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind review because urgent

@karthikeyann
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #9283 (3093747) into branch-21.10 (3ee3ecf) will decrease coverage by 0.10%.
The diff coverage is 12.05%.

❗ Current head 3093747 differs from pull request most recent head 10213dc. Consider uploading reports for the commit 10213dc to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #9283      +/-   ##
================================================
- Coverage         10.85%   10.75%   -0.11%     
================================================
  Files               115      116       +1     
  Lines             19158    18931     -227     
================================================
- Hits               2080     2036      -44     
+ Misses            17078    16895     -183
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/text.py 0.00% <0.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced66b5...10213dc. Read the comment docs.

@jrhemstad
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c431650 into branch-21.10 Sep 23, 2021
@karthikeyann karthikeyann deleted the revert-9185-fea-shallow_hash_columnview branch May 14, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codereport codereport codereport approved these changes

@jrhemstad jrhemstad jrhemstad approved these changes

@devavret devavret devavret approved these changes

@harrism harrism Awaiting requested review from harrism

Assignees
No one assigned
Labels
5 - DO NOT MERGE Hold off on merging; see PR for details CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karthikeyann @jrhemstad @devavret @codereport