Fixing empty input to getMapValue crashing #9262

hyperbolic2346 · 2021-09-21T02:46:32Z

This changes the calls in java/cudf to check for an empty input and return an empty result instead of crashing.

codecov · 2021-09-21T04:16:24Z

Codecov Report

Merging #9262 (8ab87fe) into branch-21.10 (3ee3ecf) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 8ab87fe differs from pull request most recent head 9da155a. Consider uploading reports for the commit 9da155a to get more accurate results

@@               Coverage Diff                @@
##           branch-21.10    #9262      +/-   ##
================================================
- Coverage         10.85%   10.84%   -0.01%     
================================================
  Files               115      116       +1     
  Lines             19158    19171      +13     
================================================
  Hits               2080     2080              
- Misses            17078    17091      +13

Impacted Files	Coverage Δ
python/cudf/cudf/__init__.py	`0.00% <ø> (ø)`
python/cudf/cudf/_lib/__init__.py	`0.00% <ø> (ø)`
python/cudf/cudf/core/multiindex.py	`0.00% <0.00%> (ø)`
python/cudf/cudf/io/__init__.py	`0.00% <0.00%> (ø)`
python/cudf/cudf/io/text.py	`0.00% <0.00%> (ø)`
python/cudf/cudf/utils/ioutils.py	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625810a...9da155a. Read the comment docs.

java/src/main/native/src/map_lookup.cu

jlowe

There should also be an added Java unit test for this case to catch any regressions in the future.

hyperbolic2346 · 2021-09-22T02:29:02Z

New test before changes:

[ERROR] testGetMapValueEmptyInput  Time elapsed: 0.002 s  <<< ERROR!
ai.rapids.cudf.CudfException: cuDF failure at: /home/knobby/code/rapids/compose/etc/conda/envs/rapids/include/cudf/detail/utilities/cuda.cuh:65: num_blocks must be > 0
	at ai.rapids.cudf.ColumnView.mapLookup(Native Method)
	at ai.rapids.cudf.ColumnView.getMapValue(ColumnView.java:2972)
	at ai.rapids.cudf.ColumnVectorTest.testGetMapValueEmptyInput(ColumnVectorTest.java:5420)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:628)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:117)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:184)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:180)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:127)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:68)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:170)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:154)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:90)
	at org.junit.platform.surefire.provider.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:132)
	at org.junit.platform.surefire.provider.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:111)
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:383)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:344)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:417)

After changes:

[INFO] Running ai.rapids.cudf.ColumnVectorTest
[WARNING] Tests run: 283, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 0.715 s - in ai.rapids.cudf.ColumnVectorTest

jlowe

Need to update copyrights but otherwise lgtm.

java/src/main/native/src/map_lookup.cu

hyperbolic2346 · 2021-09-22T15:34:23Z

HTTP 504 GATEWAY TIME-OUT for url <https://conda.anaconda.org/conda-forge/linux-64/_libgcc_mutex-0.1-conda_forge.tar.bz2>

hyperbolic2346 · 2021-09-22T15:42:25Z

rerun tests

hyperbolic2346 · 2021-09-22T18:31:09Z

@gpucibot merge

Fixing empty input crashing

a1ea2d3

hyperbolic2346 requested a review from a team as a code owner September 21, 2021 02:46

github-actions bot added the Java Affects Java cuDF API. label Sep 21, 2021

hyperbolic2346 added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Sep 21, 2021

jlowe reviewed Sep 21, 2021

View reviewed changes

java/src/main/native/src/map_lookup.cu Outdated Show resolved Hide resolved

jlowe reviewed Sep 21, 2021

View reviewed changes

hyperbolic2346 changed the title ~~Fixing empty input crashing~~ Fixing empty input to getMapValue crashing Sep 21, 2021

changes from review

d261ec8

removing whitespace addition

5c3c991

jlowe reviewed Sep 22, 2021

View reviewed changes

java/src/main/native/src/map_lookup.cu Show resolved Hide resolved

updating copyright

9da155a

hyperbolic2346 requested a review from jlowe September 22, 2021 13:59

jlowe approved these changes Sep 22, 2021

View reviewed changes

rapids-bot bot merged commit ef5ba4c into rapidsai:branch-21.10 Sep 22, 2021

hyperbolic2346 deleted the mwilson/map_lookup_bug9253 branch September 22, 2021 18:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing empty input to getMapValue crashing #9262

Fixing empty input to getMapValue crashing #9262

hyperbolic2346 commented Sep 21, 2021

codecov bot commented Sep 21, 2021 •

edited

Loading

jlowe left a comment

hyperbolic2346 commented Sep 22, 2021

jlowe left a comment

hyperbolic2346 commented Sep 22, 2021

hyperbolic2346 commented Sep 22, 2021

hyperbolic2346 commented Sep 22, 2021

Fixing empty input to getMapValue crashing #9262

Fixing empty input to getMapValue crashing #9262

Conversation

hyperbolic2346 commented Sep 21, 2021

codecov bot commented Sep 21, 2021 • edited Loading

Codecov Report

jlowe left a comment

Choose a reason for hiding this comment

hyperbolic2346 commented Sep 22, 2021

jlowe left a comment

Choose a reason for hiding this comment

hyperbolic2346 commented Sep 22, 2021

hyperbolic2346 commented Sep 22, 2021

hyperbolic2346 commented Sep 22, 2021

codecov bot commented Sep 21, 2021 •

edited

Loading