Code

Refactor MD5 implementation.#9212

Code

Merged

rapids-bot[bot] merged 54 commits intorapidsai:branch-21.12rapidsai/cudf:branch-21.12from bdice:refactor-md5bdice/cudf:refactor-md5Copy head branch name to clipboardOct 21, 2021

+294-404

Commits

Commits on Sep 10, 2021

• Improve comments and naming.

  bdice

  committed
  9d158e8

• Remove unused seed from MD5Hash constructor.

  bdice

  committed
  5630eed

• Expand detail namespace.

  bdice

  committed
  f23735d

• Remove seed and default constructors.

  bdice

  committed
  ed56ef0

• Move MD5 implementations from hash_functions.cuh to md5_hash.cu because they are only used in that file.

  bdice

  committed
  03bfe6d

Commits on Sep 20, 2021

• Change to unsigned types for md5_chunk_size.

  Show description for 7945efe
  

  bdice

  and

  vyasr

  authored
  7945efe

• Remove unused parameter names.

  Show description for 81bf129
  

  bdice

  and

  davidwendt

  authored
  81bf129

Commits on Sep 28, 2021

• clang-format.

  bdice

  committed
  ab3779b

• Replace magic number with named constant.

  bdice

  committed
  d2c4a0c

Commits on Oct 1, 2021

• Use memcpy instead of std::memcpy, add comments.

  bdice

  committed
  bd766bf

• Intermediate stage with optional iterator experiments on device.

  bdice

  committed
  e961f7c

• Revert changes to column_device_view.cuh.

  bdice

  committed
  65446ed

• Clean up duplication in typed element processing.

  bdice

  committed
  b6d166b

• More cleanup.

  bdice

  committed
  60da684

• Simplify message length.

  bdice

  committed
  3940daa

• Make normalization pass-through for non-floating fixed-width types.

  bdice

  committed
  6af5451

• Prefer char over uint8_t.

  bdice

  committed
  b33ea93

• Improve helper functions.

  bdice

  committed
  af42f7e

• Refactor finalize.

  bdice

  committed
  f3038e1

• Rename message length variable.

  bdice

  committed
  e8c6e3e

• Additional simplifications to finalize.

  bdice

  committed
  c6867e6

• Simplify padding.

  bdice

  committed
  4e8817e

Commits on Oct 11, 2021

• Consolidate MD5 hash constants into .cu file, remove includes.

  bdice

  committed
  f83cfe0

Commits on Oct 12, 2021

• Implement hash_circular_buffer.

  bdice

  committed
  37cb283

Commits on Oct 13, 2021

• Remove non-const accessor.

  bdice

  committed
  a3be658

• Replace SFINAE with constexpr if.

  bdice

  committed
  088fa89

• Refactor buffer and hash_step callbacks.

  bdice

  committed
  331107b

• Move processing functions around.

  bdice

  committed
  af98bab

• MD5Hasher now owns its hash state.

  bdice

  committed
  e604f14

Commits on Oct 14, 2021

• Use HasherDispatcher to avoid unexpected memory access error with type dispatch.

  bdice

  committed
  7ff0e72

• Move methods from md5_hash_state to MD5Hasher class.

  bdice

  committed
  167dab3

• Improve naming.

  bdice

  committed
  a8ac635

Commits on Oct 15, 2021

• Use destructor instead of finalize method.

  bdice

  committed
  e8b61dd

• Avoid double type dispatch for list columns.

  bdice

  committed
  5150c5e

• Remove hash_state class.

  bdice

  committed
  3715e25

• Refactoring hash step callback structure.

  bdice

  committed
  677c2fe

• Remove MD5Hasher.put.

  bdice

  committed
  720b601

• Remove MD5Hasher.pad.

  bdice

  committed
  55e4bce

Commits on Oct 18, 2021

• Move hash_values to be part of the hash step's state.

  bdice

  committed
  27a8bf0

• Construct hash step explicitly, use message_chunk_size for buffer sizes.

  bdice

  committed
  e56e1d6

• Make MD5Hash own the hash_values.

  bdice

  committed
  5544d87

• Move variable.

  bdice

  committed
  ff038cd

Commits on Oct 20, 2021

• Declare HasherDispatchers inline.

  bdice

  committed
  cc2bf4b

• Make HasherDispatcher column_device_view const&.

  bdice

  committed
  9fd47fa

• Parenthesize expression for readability.

  bdice

  committed
  f12eaf8

• Add const.

  bdice

  committed
  2f5c2b6

• Rename Key to Element, get_data to get_element_pointer_and_size.

  bdice

  committed
  25c0e90

• Add constructor to HasherDispatcher.

  bdice

  committed
  b6c4c75

Commits on Oct 21, 2021

• Simplify hash_circular_buffer.

  bdice

  committed
  d7ff965

• Reformat shift constants.

  bdice

  committed
  8cdf423

• Add comment.

  bdice

  committed
  e7834dd

• Remove unnecessary qualifiers.

  bdice

  committed
  92b329b

• Add comment about constant sources.

  bdice

  committed
  410b30d

• Clarify flag.

  bdice

  committed
  c7d132f