-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Cython APIs for table view generation #9199
Remove Cython APIs for table view generation #9199
Conversation
958bd9f
to
582ef25
Compare
Co-authored-by: Michael Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as above.
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9199 +/- ##
===============================================
Coverage ? 10.82%
===============================================
Files ? 115
Lines ? 19166
Branches ? 0
===============================================
Hits ? 2074
Misses ? 17092
Partials ? 0 Continue to review full report at Codecov.
|
@isVoid OK I went through and checked all the files. I think I got all the places where I was passing through a raw boolean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this mostly looks good from my end. But I think we should wait until the maintainers mentioned above comment on this.
Agreed, I don't plan to merge until other maintainers can take a look. |
Got the OK on this from @dantegd offline |
I re-checked cuGraph and didn't see anything that's using these Cython APIs, so this change should be safe for cuGraph. I believe we're only using public cuDF python APIs in the pure python layer. |
OK great. I've opened rapidsai/cuspatial#449 to make cuspatial work after this PR, so we should be good to go once this PR is merged. |
@gpucibot merge |
This makes cuspatial compatible with the changes in rapidsai/cudf#9199. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - H. Thomson Comer (https://github.com/thomcom) URL: #449
This PR removes the Table methods used to generate
cudf::table_view
objects in Cython and switches all code paths to use the underlyingcdef
function that those functions originally called under the hood. Many of the view-generating functions were actually never used (all the mutable view generators andindex_view
), so those have been removed. Moving in this direction has two benefits. First, it allows us to change our Cython APIs to accept iterables of columns rather thanTable
objects, which in turn means that we can get rid of various Column->Table->Column round-trips that are currently in place just to call Cython APIs on Columns that are only defined on Tables. Second, the Table class is now pure Python, so its logic can be merged into the Frame class.