Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gather() for STRUCT inputs with no nulls in members. #9194

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Fix gather() for STRUCT inputs with no nulls in members. #9194

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8f36cf
Fix gather for inputs with no nulls:
mythrocks Sep 8, 2021
bf030d9
Merge remote-tracking branch 'origin/branch-21.10' into fix-structs-g…
mythrocks Sep 13, 2021
23f52e5
Reviews: Using directives, and or.
mythrocks Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cpp/include/cudf/detail/gather.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,9 +470,10 @@ struct column_gatherer_impl<struct_view> {
mr);
});

auto const nullable = std::any_of(structs_column.child_begin(),
structs_column.child_end(),
[](auto const& col) { return col.nullable(); });
auto const nullable =
nullify_out_of_bounds || std::any_of(structs_column.child_begin(),
mythrocks marked this conversation as resolved.
Show resolved Hide resolved
structs_column.child_end(),
[](auto const& col) { return col.nullable(); });
if (nullable) {
gather_bitmask(
// Table view of struct column.
Expand Down
Loading