-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor C++17 cleanup of groupby.cu
: structured bindings, more concise lambda, etc
#9193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, apart from thing failing with rmm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PR description somehow ends up in the changelog so you may want to consider replacing it with something more descriptive.
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9193 +/- ##
===============================================
Coverage ? 10.77%
===============================================
Files ? 115
Lines ? 19138
Branches ? 0
===============================================
Hits ? 2062
Misses ? 17076
Partials ? 0 Continue to review full report at Codecov.
|
groupby.cu
: CTAD, structured bindings, more concise lambdagroupby.cu
: structured bindings, more concise lambda, etc
@gpucibot merge |
Due to the fact that my soul is slowly melting away due to my current internal PR I am working on, I set up this small cleanup in hopes of getting a dopamine or endorphin hit.