-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit about bitwidth difference between cudf boolean and arrow boolean #9192
Conversation
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9192 +/- ##
===============================================
Coverage ? 10.83%
===============================================
Files ? 116
Lines ? 18779
Branches ? 0
===============================================
Hits ? 2035
Misses ? 16744
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create a test that publicly exposes this change? This kind of bit managing is easy to overlook later and a test would reveal if it is missed.
rerun tests |
@gpucibot merge |
Currently, we map boolean type to
pa.int8
because the bitwidth of cudf boolean mismatches that in arrow. However the implication of this mapping is subtle and may cause unwanted result such as:This PR changes the mapping back to
pa.bool_
, and use explicit type handling when we are dealing with type conversion to arrow.