get_cucollections properly uses rapids_cpm_find #9189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9189 +/- ##
===============================================
Coverage ? 10.78%
===============================================
Files ? 115
Lines ? 19115
Branches ? 0
===============================================
Hits ? 2062
Misses ? 17053
Partials ? 0 Continue to review full report at Codecov.
|
kkraus14
approved these changes
Sep 9, 2021
|
Looks like I'm no longer a cmake codeowner 😢. Either way this LGTM. |
harrism
approved these changes
Sep 17, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #9030 was merged it incorrectly resolved
get_cucollections.cmaketo use features ofrapids_cpm_findbut still callCPMFindPackage. This corrects the issues by properly callingrapids_cpm_find.