Add shallow equality comparison for column_view #9187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
added
feature request
jrhemstad
reviewed
Sep 7, 2021
cpp/src/column/column_view.cpp
Outdated
Comment on lines
101
to
103
| return (lhs.type() == rhs.type()) and (lhs.size() == rhs.size()) and | ||
| (lhs.head() == rhs.head()) and (lhs.null_mask() == rhs.null_mask()) and | ||
| (lhs.offset() == rhs.offset()) and |
There was a problem hiding this comment.
Same comment here, we shouldn't include the header() or null_mask() when size() is 0.
|
I think this PR can be merged with #9185 into a single PR. |
Co-authored-by: Jake Hemstad <[email protected]>
…/cudf into fea-shallow_equal_columnview
|
merged with PR #9185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9139
Depends on PR #9185 (for unit tests only)
Use commit 88726a4 for code review.
Added shallow_equal(column_view, column_view)
Added unit tests
It compares two column_views based on the shallow states of column_view:
type, size, data pointer, null_mask pointer, offset, and the column_view of the children.
null_count is not used since it is a cached value and it may vary based on contents of null_mask, and may be pre-computed or not.