Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapids-export correctly reference build code block and doc strings #9186

Conversation

robertmaynard
Copy link
Contributor

The update to rapids-cmake, introduced two regressions that this PR fixes.

  1. re-include the a documentation header to the cudf-config.cmake files describing the project
  2. The build directory cudf-config.cmake properly recreates testing dependencies and the cudf::Thrust target

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Sep 7, 2021
@robertmaynard robertmaynard requested a review from a team as a code owner September 7, 2021 19:28
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Sep 7, 2021
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@8a3efd0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9186   +/-   ##
===============================================
  Coverage                ?   10.78%           
===============================================
  Files                   ?      115           
  Lines                   ?    19113           
  Branches                ?        0           
===============================================
  Hits                    ?     2062           
  Misses                  ?    17051           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3efd0...de49143. Read the comment docs.

@harrism
Copy link
Member

harrism commented Sep 7, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit be858a7 into rapidsai:branch-21.10 Sep 7, 2021
@robertmaynard robertmaynard deleted the bug/correctly_reference_build_code_block branch September 8, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants