Approximate overflow detection in ORC statistics #9163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9163 +/- ##
===============================================
Coverage ? 10.82%
===============================================
Files ? 115
Lines ? 19125
Branches ? 0
===============================================
Hits ? 2070
Misses ? 17055
Partials ? 0 Continue to review full report at Codecov.
|
jrhemstad
approved these changes
Sep 2, 2021
devavret
approved these changes
Sep 2, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9136
When converting statistics chunks, has_sum is conditioned on the result of overflow detection. Detection is very pessimistic so sum is not included is all cases where there's a chance of overflow based on min/max values in the column.