Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use decimal precision metadata when reading from parquet files #9162

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Use decimal precision metadata when reading from parquet files #9162

merged 2 commits into from
Sep 2, 2021

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Sep 1, 2021

Closes #8354.

@shwina shwina requested a review from a team as a code owner September 1, 2021 20:52
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 1, 2021
@shwina shwina added non-breaking Non-breaking change bug Something isn't working labels Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@1935a8a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9162   +/-   ##
===============================================
  Coverage                ?   10.82%           
===============================================
  Files                   ?      115           
  Lines                   ?    19125           
  Branches                ?        0           
===============================================
  Hits                    ?     2070           
  Misses                  ?    17055           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1935a8a...d701a0e. Read the comment docs.

@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 858944b into rapidsai:branch-21.10 Sep 2, 2021
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule left review comments

@galipremsagar galipremsagar galipremsagar approved these changes

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Reading/writing decimal columns to parquet loses precision
3 participants
@shwina @galipremsagar @vuule