Fix struct and list dtype logic in dask_cudf.read_parquet #9159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9159 +/- ##
===============================================
Coverage ? 10.85%
===============================================
Files ? 115
Lines ? 18742
Branches ? 0
===============================================
Hits ? 2034
Misses ? 16708
Partials ? 0 Continue to review full report at Codecov.
|
rjzamora
added
3 - Ready for Review
galipremsagar
added a commit
to galipremsagar/cudf
that referenced
this pull request
Sep 14, 2021
|
Closing in favor of #9203 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
A similar fix for this problem was recently submitted in #9159 and closed in favor of #9203. It seems that the test added in the latter PR was not actually capturing the original problem. However, after [dask#8072](dask/dask#8072) is merged, the new test will certainly start failing. Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Benjamin Zaitlen (https://github.com/quasiben) URL: #9314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dask_cudf.read_parquetlogic currently uses a utility calledset_object_dtypes_from_pa_schemato cast dtypes into proper cudf/pyarrow dtypes. The same utility is used to both (1) "reset"pandas.DataFramemetadata to agree with the pyarrow schema, and (2) to castcudf.DataFramepartitions to the "correct" dtypes at IO time. In both cases, thepd/cudf.DataFramecolumns cannot be cast to cudf list and/or struct columns. Therefore, this PR simply adds a simpole check to avoid casting for list/struct dtypes. We also add a new test (test_cudf_dtypes_from_pandas) to add test coverage for the original bug.