Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Upgrade pandas version in cudf #9147

Merged
merged 42 commits into from
Sep 8, 2021
Merged

[REVIEW] Upgrade pandas version in cudf #9147

merged 42 commits into from
Sep 8, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Aug 31, 2021 •
edited
Loading

Fixes: #9125

This PR:

  • Upgrades pandas to its latest version - 1.3.2
  • Fixes multiple hidden issues in cudf that were fixed as part of the latest pandas release.
  • Introduces xfail at multiple places which are essentially regressions in the latest pandas release.
  • Split up and refactor some pytests that will help us determine failures easily and are maintainable.

@galipremsagar galipremsagar added the 2 - In Progress Currently a work in progress label Aug 31, 2021
@galipremsagar galipremsagar self-assigned this Aug 31, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner August 31, 2021 02:57
@galipremsagar galipremsagar requested a review from a team as a code owner August 31, 2021 02:57
@galipremsagar galipremsagar requested review from vyasr and shwina August 31, 2021 02:57
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Aug 31, 2021
@galipremsagar galipremsagar marked this pull request as draft August 31, 2021 02:58
@github-actions github-actions bot added the gpuCI label Sep 2, 2021
@galipremsagar galipremsagar added breaking Breaking change and removed gpuCI labels Sep 2, 2021
@galipremsagar galipremsagar added the 3 - Ready for Review Ready for review by team label Sep 4, 2021
@galipremsagar galipremsagar mentioned this pull request Sep 4, 2021
Merged
galipremsagar
galipremsagar commented Sep 4, 2021
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the gpuCI label Sep 7, 2021
shwina
shwina reviewed Sep 7, 2021
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is invaluable work, @galipremsagar!

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 7, 2021
@galipremsagar
Copy link
Contributor Author

@shwina I made a trivial fix to a failure being caused by latest dask upstream changes: 1ded3a3

This was to match pandas get_slice_bound function signature.

@galipremsagar
Copy link
Contributor Author

rerun tests

1 similar comment
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

2 similar comments
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e9caed3 into rapidsai:branch-21.10 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjacobelli jjacobelli jjacobelli approved these changes

@shwina shwina shwina approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Milestone
Pandas API Alignment and Coverage
Development

Successfully merging this pull request may close these issues.

[FEA] Upgrade pandas to 1.3.2 in cudf
3 participants
@galipremsagar @shwina @jjacobelli